Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This removes dead code and makes it clearer to readers what should be returned from functions, especially inline ones. It should also prevent one-line functions from accidentally not returning what they returned before when getting refactored to multi-line.
jtran
force-pushed
the
jtran-unused-exprs-lint
branch
from
8809a74 to
f5765e3
Compare
jtran
commented
Apr 6, 2026
| selectionType: 'singleCodeCursor', | ||
| }, | ||
| }) && | ||
| setHasClearedSelection(true) |
Contributor
Author
There was a problem hiding this comment.
According to the lint, this line was dead code. When I made it always run, lots of tests failed.
Contributor
Author
There was a problem hiding this comment.
@pierremtb, what do you think about this change. Looks like you added this in #7106.
Contributor
Author
|
This isn't a priority to merge. I'd like to get a real review since I don't want to break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes dead code and makes it clearer to readers what should be returned from functions. It should prevent one-line functions from accidentally not returning what they returned before when getting refactored to multi-line.