Skip to content

Remove SketchBlock operation in favor of a new Group type#10838

Draft
pierremtb wants to merge 30 commits intomainfrom
pierremtb/jtran-node-path
Draft

Remove SketchBlock operation in favor of a new Group type#10838
pierremtb wants to merge 30 commits intomainfrom
pierremtb/jtran-node-path

Conversation

@pierremtb
Copy link
Copy Markdown
Contributor

@pierremtb pierremtb commented Apr 6, 2026

Stacked on #10780.

Started as just a little fix but now pivoted to using the Group approach to deal with nested items under a sketch block.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Apr 8, 2026 4:14pm

Request Review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 6, 2026

Merging this PR will not alter performance

✅ 167 untouched benchmarks
⏩ 93 skipped benchmarks1


Comparing pierremtb/jtran-node-path (e7d8a23) with main (2b8de9f)2

Open in CodSpeed

Footnotes

  1. 93 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (116b517) during the generation of this report, so 2b8de9f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Comment on lines 63 to 72
Copy link
Copy Markdown
Contributor

@jtran jtran Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were me, I would delete this since the information is now in the GroupBegin and its Group. It makes it more similar to how function calls work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pierremtb pierremtb changed the title TS update for jtran-node-path TS updates for #10780 Apr 6, 2026
@pierremtb pierremtb changed the title TS updates for #10780 Remove SketchBlock operation in favor of a new Group type Apr 7, 2026
Base automatically changed from jtran-node-path to main April 7, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants