Update Center Rectangle tool to have center point, construction lines#10941
Merged
franknoirot merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Vercel won't connect to an engine so can't test rn. Is there a way I or someone else can give it a kick? |
Contributor
|
@jamwaffles I'm not sure. It's loading for me:
|
jacebrowning
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Addresses a concern raised by @alteous and @jamwaffles regarding our Center Rectangle sketch tool, which until now has been a light wrapper around the corner rectangle tool. Now it matches other CAD tool implementations, with equal diagonal construction lines between opposing corners, and a point coincident to both lines.
This also adds proper snapping behavior to the rectangle tool family, which had been being swallowed by the tool's state machine.
Demo
Screenshare.-.2026-04-09.3_16_42.PM-compressed.mp4
Codex-assisted, sorry @jamwaffles
Initial prompt: