Skip to content

KCL: Nicer error messages#10956

Merged
adamchalmers merged 4 commits intomainfrom
achalmers/fix-error-msgs
Apr 10, 2026
Merged

KCL: Nicer error messages#10956
adamchalmers merged 4 commits intomainfrom
achalmers/fix-error-msgs

Conversation

@adamchalmers
Copy link
Copy Markdown
Contributor

@adamchalmers adamchalmers commented Apr 10, 2026

Fixes #10855. As Jon pointed out, there were many places that the KCL was including Rust debug strings instead of printing nice, human-friendly error messages. I've gone through and found a bunch of these, replacing the debug strings with better messages.

Here's one such example. Before:

bad_msg

After:

Screenshot 2026-04-09 at 9 33 53 PM

@adamchalmers adamchalmers requested a review from a team as a code owner April 10, 2026 02:35
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Apr 10, 2026 3:13am

Request Review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2026

Merging this PR will not alter performance

✅ 167 untouched benchmarks
🆕 2 new benchmarks
⏩ 93 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation parse_big_sketch_block N/A 120.7 ms N/A
🆕 Simulation bench_edit_segment N/A 709.5 ms N/A

Comparing achalmers/fix-error-msgs (dda53e3) with main (007cc86)2

Open in CodSpeed

Footnotes

  1. 93 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (b051d9b) during the generation of this report, so 007cc86 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@adamchalmers adamchalmers merged commit 4fbe9bb into main Apr 10, 2026
78 checks passed
@adamchalmers adamchalmers deleted the achalmers/fix-error-msgs branch April 10, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sketch solve: don't use Rust error string

3 participants