Fix hotkeys for toolbar items that are first in dropdown#10959
Open
franknoirot wants to merge 1 commit intomainfrom
Open
Fix hotkeys for toolbar items that are first in dropdown#10959franknoirot wants to merge 1 commit intomainfrom
franknoirot wants to merge 1 commit intomainfrom
Conversation
Codex-assisted. I suspected that Arc and Rectangle hotkeys weren't working because of a duplicate hotkey listener, one for the button and one for the dropdown menu entry. This fixes that by removing a duplicate hotkey registration in the dropdown items, centralizing toolbar hotkey registration. Adds some integration tests. Test by hitting <kbd>A</kbd> in sketch mode and having it actually work.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex-assisted. I suspected that Arc and Rectangle hotkeys weren't working because of a duplicate hotkey listener, one for the button and one for the dropdown menu entry. This fixes that by removing a duplicate hotkey registration in the dropdown items, centralizing toolbar hotkey registration. Adds some integration tests. Test by hitting A in sketch mode and having it actually work.