Add ability to double-click sketch solve entities to enter sketch editing#10960
Open
franknoirot wants to merge 2 commits intomainfrom
Open
Add ability to double-click sketch solve entities to enter sketch editing#10960franknoirot wants to merge 2 commits intomainfrom
franknoirot wants to merge 2 commits intomainfrom
Conversation
…ting Closes #10867. Codex-assisted.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewvarga
approved these changes
Apr 10, 2026
Contributor
andrewvarga
left a comment
andrewvarga
left a comment
There was a problem hiding this comment.
Nice!
Double clicking on regions still doesn't work, is that something we want to do as well?
If yes it looks like there is some code in selections.ts already that resolves a region that can be useful, but no need to do in this PR even if we want to go for it eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10867. Codex-assisted.
Demo
Worth noting that this does not fix the "animating to wrong side of a sketch" bug, which you can see at the end of this video. That is tracked in #10847.
Screenshare.-.2026-04-10.1_29_04.AM-compressed.mp4