[TMDb] Fix duplicate include_adult parameter in movie search#1995
Open
RawScape wants to merge 1 commit into
Open
[TMDb] Fix duplicate include_adult parameter in movie search#1995RawScape wants to merge 1 commit into
RawScape wants to merge 1 commit into
Conversation
The include_adult parameter was appended to the search query twice, causing TMDb to reject requests with HTTP 400. Fixes Komet#1992
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1992.
The
include_adultquery parameter was being appended twice to TMDbmovie search URLs, causing TMDb to reject the requests with HTTP 400.
In
TmdbMovieSearchJob::doStart(),includeAdultwas passed both asa direct argument to
getMovieSearchUrl()(which adds it to thequery) and again via the
UrlParameterMapusingApiUrlParameter::INCLUDE_ADULT. Removed the redundant map entry inboth code paths so the parameter is now sent exactly once.
Testing: Verified the final request URL contains
include_adultexactly once and that movie search returns results again instead of
HTTP 400.