Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix TypeError in Online Serving + vLLM video inference parameters
Hi Kwai Team, thank you for the great work and for reviewing this PR.
Summary
return_video_kwargsargument toprocess_vision_info.Changes
return_video_kwargs=Truefrom the demo/serving code.video_kwargs.Rationale
process_vision_infoinsrc/keye_vl_utils/vision_process.pydoesn’t acceptreturn_video_kwargs; passing it raises:vLLM Notes (to avoid freezes with long videos)
--max-num-batched-tokens 80960: avoids batching issues with long sequences--max-model-len 80960: supports extended context from video framesTesting