Fix rand.Seed initialization and data races in progress bars - #6
Open
msarg44 wants to merge 1 commit into
Open
Conversation
- Add rand.Seed(time.Now().UnixNano()) in init() to ensure random host/port order when !seqMode (Go 1.16-1.19 require explicit seeding; without it, shuffle produces identical results every run) - Fix data races in ProgressBar() and RejectAllOpenProgressBar() where shared counters (doneCount, hostUpCount, openCount, hostDiscard, stopRejectAllOpenProgressBar) were read without holding the mutex that protects their writes
Owner
|
Thanks for submitting, but the counting variable name will simply retain the original name to improve readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for correctness issues:
1. Add
rand.Seed(time.Now().UnixNano())ininit()The project declares
go 1.16and usesrand.Shuffle()inIPCIDR()andIPWildcard()for non-sequential mode. Go 1.16–1.19 require explicit seeding viarand.Seed()— without it, the shuffle produces identical ordering every run, defeating the purpose of!seqMode.2. Fix data races in progress bar routines
ProgressBar()andRejectAllOpenProgressBar()read shared counters (doneCount,hostUpCount,openCount,hostDiscard,stopRejectAllOpenProgressBar) without holding the mutex that protects writes to these variables in worker goroutines. This is a data race per the Go memory model.Changes:
ProgressBar(): local copies of counters under mutex lock before loggingRejectAllOpenProgressBar(): same treatment for counters, plusstopRejectAllOpenProgressBarreads under mutexBoth fixes verified to compile with
go 1.16through current Go versions.