Skip to content

Compile queue: close the test gaps the #1728 reviews deferred #1731

Open

Description

@christianparpart

Follow-up to #1728. The per-task reviews deferred these test gaps. None of them is a known defect, and the code paths read correct, but each is untested:

  • Settles on a demoted node. SettleAdmission with Stored, NotStored or Failed on a node that has been demoted must still release the charge and the lease. Only WorkerRefused is tested.
  • NoteDepartureCounted. The call in FrameEndpoint's AbandonIfPeerGone has no case driving it. Deleting it would double-count AdmissionAbandoned and nothing would go red. The gap is noted at the call site.
  • The launcher's pendingRefusal / granted wiring in src/apps/pace-cc/main.cpp. main.cpp is in no test target. RunMiss's seams are tested, but the lambda that records a held plan refusal only after a grant is not.
  • RelaysByVerb attribution (Responders.hpp). A non-relayed ADMIT on a follower, from a remote launcher or our own key, gets the forwarder's PeerWatchCounter. A departure is then filed as pace_admission_forward_abandoned_total.
  • Refactor. PresenceRound's bool* reachedScheduler out-parameter should become a returned {accepted, reached} value, the house idiom.

Activity

  1. added
    type/testCoverage gaps, flaky or unbuilt test targets, e2e fixtures
    area/distributedDistributed/, apps/fastcache-compile-node/ - dispatch, workers, scheduler
    on Oct 28, 2026
  2. christianparpart commented on Oct 28, 2026

    @christianparpart
    MemberAuthor

    One more gap from the final review of #1728: a8092d3 (a connection's admission hold is released before FrameEndpoint stops counting it as open) has no test. The candidate test was removed because it stayed green with the fix reverted. A test that discriminates: give a hold a release callback that reads the server's open count and asserts it is still 1 or more at release time. That needs OpenCount exposed to tests; today it lives on the internal State.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/distributedDistributed/, apps/fastcache-compile-node/ - dispatch, workers, schedulertype/testCoverage gaps, flaky or unbuilt test targets, e2e fixtures

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions