[Bugfix]: utils::sqrt no longer maps negative values to 1#175
Open
PROWLERx15 wants to merge 3 commits intoLFDT-Lockness:cggmp24/mfrom
Open
[Bugfix]: utils::sqrt no longer maps negative values to 1#175PROWLERx15 wants to merge 3 commits intoLFDT-Lockness:cggmp24/mfrom
PROWLERx15 wants to merge 3 commits intoLFDT-Lockness:cggmp24/mfrom
Conversation
Signed-off-by: PROWLERx15 <prowlerx15@gmail.com>
Signed-off-by: PROWLERx15 <prowlerx15@gmail.com>
maurges
requested changes
Apr 22, 2026
| epsilon: L::EPSILON, | ||
| }; | ||
| let n_sqrt = utils::sqrt(&N); | ||
| let n_sqrt = utils::sqrt(&N).expect("Own modulus N is always positive"); |
There was a problem hiding this comment.
We ban the use of unwrap and expect in our code (except in tests). Here you should instead create a new variant of the key_refresh::Bug enum and return it
Author
There was a problem hiding this comment.
noted. i've replaced it with Bug::NegativeModulus
Comment on lines
150
to
152
| pub fn sqrt(x: &Integer) -> Option<Integer> { | ||
| x.sqrt_ref() | ||
| } |
There was a problem hiding this comment.
This function is currently just a piece of tech debt - it's a remnant from the time when our big integer backend didn't have the sqrt method. You should remove it completely and use sqrt_ref directly. Obviously the test below is also unnecessary anymore
Author
There was a problem hiding this comment.
i've removed utils::sqrt entirely and replaced it with sqrt_ref(). also removed the test_sqrt since it is no longer needed
Signed-off-by: PROWLERx15 <prowlerx15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
utils::sqrtused to return1whenInteger::sqrt_ref()wasNone(negative input). That hid bad values and made ZK failures harder to trace and debug.sqrtnow returnsOption<Integer>and delegates tosqrt_ref(). Call sites in aux key refresh use.expect()for our own modulus and treatNoneas a fault when verifying another party’s decommitment.Tests updated accordingly.