fix: only count gateway as used IP when it falls within the CIDR range#126
Merged
fix: only count gateway as used IP when it falls within the CIDR range#126
Conversation
When the gateway IP is outside the allocation CIDR (e.g. gateway 148.113.164.254 for range 15.235.3.224/28), it was still unconditionally added to the used-IP set. This inflated ips.len() and triggered the early-exit ips.len() >= size check, falsely reporting the range as full when free IPs remained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pick_ip_from_range, the gateway IP was unconditionally inserted into the used-IPHashSet, even when the gateway fell outside the allocation CIDRips.len()and triggered the early-exitips.len() >= sizecheck, falsely reporting the range as full when free IPs remained15.235.3.224/28(16 IPs) with gateway148.113.164.254(outside CIDR), 15 assigned IPs →.237was free but the range was reported as fullFix
range_cidr.contains(gateway.ip()), consistent with howcount_available_ipsalready handles this casetest_pick_ip_gateway_outside_range_not_full