Switch requests to path first URLs #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor selectRows, makeFilter.
…e both newer and legacy filter formats. Update remaining functions to use the new labkey.buildURL utility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
labkey.buildURLto handle URL generation. This includes moving the folderPath validation into this method and out of the calling function. Leverage thehttrlibrary to generate the URL including any query parameters and URL encoding.selectRowsto consolidate parameter generation for both GET and POST methodsmakeFilterto support generating filter lists using named elements. This is the format that thehttrutilities can accept for URL params more readily. While we aren't making use of this variant in this update, the plan is to eventually migrate to this format by default in a future release of Rlabkey. Until then, we support both the legacy and newer formats for functions that consume the return value ofmakeFilter.Related Pull Requests
LabKey/testAutomation#2857