Skip to content

Wire enable_multi_writes through C API backend #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Apr 25, 2026
Merged

Wire enable_multi_writes through C API backend #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src_py/_lbug_capi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class _LbugSystemConfig(ctypes.Structure):
("checkpoint_threshold", ctypes.c_uint64),
("throw_on_wal_replay_failure", ctypes.c_bool),
("enable_checksums", ctypes.c_bool),
("enable_multi_writes", ctypes.c_bool),
]
if sys.platform == "darwin":
_fields_.append(("thread_qos", ctypes.c_uint32))
Expand Down Expand Up @@ -972,10 +973,6 @@ def __init__(
enable_checksums: bool = True,
enable_multi_writes: bool = False,
):
if enable_multi_writes:
raise NotImplementedError(
"enable_multi_writes is not yet wired in C-API backend"
)
self._database = _LbugDatabase()
config = _LIB.lbug_default_system_config()
config.buffer_pool_size = buffer_pool_size
Expand All @@ -988,6 +985,7 @@ def __init__(
config.checkpoint_threshold = checkpoint_threshold
config.throw_on_wal_replay_failure = throw_on_wal_replay_failure
config.enable_checksums = enable_checksums
config.enable_multi_writes = enable_multi_writes

state = _LIB.lbug_database_init(
database_path.encode("utf-8"), config, ctypes.byref(self._database)
Expand Down
2 changes: 0 additions & 2 deletions test/capi_xfails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
"test/test_issue.py::test_empty_list2",
"test/test_issue.py::test_empty_map",
"test/test_json.py::test_to_json_string_param_roundtrip",
"test/test_mvcc_bank.py::test_multi_writer_no_anomalies",
"test/test_mvcc_bank.py::test_multi_writer_stress_no_anomalies",
"test/test_parameter.py::test_empty_list_param",
"test/test_parameter.py::test_map_param",
"test/test_parameter.py::test_general_list_param",
Expand Down
Loading