Skip to content

Handle json type #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Apr 22, 2026
Merged

Handle json type #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 18 additions & 29 deletions src_cpp/py_connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,14 +393,6 @@ static LogicalType pyLogicalType(const py::handle& val) {
}
return LogicalType::DECIMAL(precision, -exponent);
} else if (py::isinstance<py::str>(val)) {
auto strVal = py::cast<std::string>(val);
if (!strVal.empty() && (strVal.front() == '{' || strVal.front() == '[')) {
auto jsonModule = py::module_::import("json");
try {
auto parsed = jsonModule.attr("loads")(val);
return pyLogicalType(parsed);
} catch (...) {}
}
return LogicalType::STRING();
} else if (py::isinstance<py::bytes>(val)) {
return LogicalType::BLOB();
Expand Down Expand Up @@ -517,6 +509,9 @@ static bool tryCastToMap(py::dict& dict, LogicalType& result) {
}

static LogicalType pyLogicalTypeFromParameter(const py::handle& val) {
if (py::isinstance<py::str>(val)) {
return LogicalType::STRING();
}
if (py::isinstance<py::dict>(val)) {
auto dict = py::reinterpret_borrow<py::dict>(val);
LogicalType resultType;
Expand Down Expand Up @@ -603,18 +598,9 @@ Value PyConnection::transformPythonValueAs(const py::handle& val, const LogicalT
}
case LogicalTypeID::STRING:
if (py::isinstance<py::str>(val)) {
auto strVal = val.cast<std::string>();
if (!strVal.empty() && (strVal.front() == '{' || strVal.front() == '[')) {
auto jsonModule = py::module_::import("json");
try {
auto parsed = jsonModule.attr("loads")(val);
return transformPythonValue(parsed);
} catch (...) {}
}
return Value::createValue<std::string>(strVal);
} else {
return Value::createValue<std::string>(py::str(val));
return Value::createValue<std::string>(val.cast<std::string>());
}
return Value::createValue<std::string>(py::str(val));
case LogicalTypeID::BLOB: {
auto bytes = py::cast<py::bytes>(val);
const char* data = PyBytes_AsString(bytes.ptr());
Expand Down Expand Up @@ -727,16 +713,6 @@ Value PyConnection::transformPythonValueAs(const py::handle& val, const LogicalT

Value PyConnection::transformPythonValueFromParameterAs(const py::handle& val,
const LogicalType& type) {
if (py::isinstance<py::str>(val)) {
auto strVal = py::cast<std::string>(val);
if (!strVal.empty() && (strVal.front() == '{' || strVal.front() == '[')) {
auto jsonModule = py::module_::import("json");
try {
auto parsed = jsonModule.attr("loads")(val);
return transformPythonValueFromParameter(parsed);
} catch (...) {}
}
}
switch (type.getLogicalTypeID()) {
case LogicalTypeID::LIST: {
if (ListType::getChildType(type).getLogicalTypeID() == LogicalTypeID::JSON) {
Expand Down Expand Up @@ -785,6 +761,9 @@ Value PyConnection::transformPythonValueFromParameterAs(const py::handle& val,
return Value(type.copy(), std::move(children));
}
case LogicalTypeID::JSON: {
if (py::isinstance<py::str>(val)) {
return Value::createValue<std::string>(py::cast<std::string>(val));
}
auto jsonStr = pythonObjectToJsonString(val);
return Value::createValue<std::string>(jsonStr);
}
Expand All @@ -802,6 +781,16 @@ Value PyConnection::transformPythonValue(const py::handle& val) {
}

Value PyConnection::transformPythonValueFromParameter(const py::handle& val) {
if (py::isinstance<py::str>(val)) {
auto strVal = py::cast<std::string>(val);
if (!strVal.empty() && (strVal.front() == '{' || strVal.front() == '[')) {
auto jsonModule = py::module_::import("json");
try {
auto parsed = jsonModule.attr("loads")(val);
return transformPythonValueFromParameter(parsed);
} catch (...) {}
}
}
auto type = pyLogicalTypeFromParameter(val);
return transformPythonValueFromParameterAs(val, type);
}
Expand Down
Loading