Conversation
adsharma
force-pushed
the
read_csr
branch
2 times, most recently
from
4e72048 to
c45c71e
Compare
Detect CSR-compatible rowid projections in the Arrow collector path and attach CSR metadata directly to ArrowQueryResult instead of rebuilding it later from a materialized row result. This adds collector-side tracking for: - src,dst rowid projections - src,rel,dst rowid projections The Arrow result still preserves any additional projected columns in the Arrow table, while exposing CSR metadata alongside the chunked Arrow batches for the relationship-shaped prefix. On the Python side, query_as_arrow() now maps to the native Arrow execution path and the dedicated Arrow result type in the submodule can read CSR from ArrowQueryResult metadata without going through the older row-oriented QueryResult path. CSR metadata is intentionally dropped when multiple local Arrow collectors merge, because unordered fan-in would make the grouped CSR structure invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect CSR-compatible rowid projections in the Arrow collector path and attach CSR metadata directly to ArrowQueryResult instead of rebuilding it later from a materialized row result.
This adds collector-side tracking for:
The Arrow result still preserves any additional projected columns in the Arrow table, while exposing CSR metadata alongside the chunked Arrow batches for the relationship-shaped prefix.
On the Python side, query_as_arrow() now maps to the native Arrow execution path and the dedicated Arrow result type in the submodule can read CSR from ArrowQueryResult metadata without going through the older row-oriented QueryResult path.
CSR metadata is intentionally dropped when multiple local Arrow collectors merge, because unordered fan-in would make the grouped CSR structure invalid.