doctor: verify timeout/gtimeout is available (Ralph loop requires it)#193
Open
selimdev00 wants to merge 1 commit into
Open
doctor: verify timeout/gtimeout is available (Ralph loop requires it)#193selimdev00 wants to merge 1 commit into
selimdev00 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bmalph doctorreports "all checks OK" on a machine where the Ralph loop cannot actually run. The loop wraps every agent call intimeout/gtimeout(.ralph/lib/timeout_utils.sh), butdoctornever verifies that command exists.On a fresh macOS without GNU coreutils, the result is:
bmalph doctor-> all greenbmalph run-> dies on loop iteration [P0] mergeClaudeMd truncates user content after BMAD section #1:So a green doctor is not a guarantee the loop will start.
Fix
Add a
timeout-availablecheck to the core registry, right after thejqcheck (both are loop runtime deps). It probes the same way the loop resolves the binary - viacommand -vinside bash - so it matches the loop's actual environment rather than the host PATH:command -v gtimeout || command -v timeoutcommand -v timeoutOn failure it fails the check with a platform-specific hint (
brew install coreutilson macOS,apt-get install coreutilson Linux, MSYS2 on Windows). On success it reports the resolved binary, e.g.timeout command available (gtimeout).Tests
checkTimeout(label, pass + resolved-binary detail, macOS gtimeout-first probe, failure hint).jq-available).