transition: don't treat the 'GO / NO-GO' heading as a NO-GO verdict#195
Open
selimdev00 wants to merge 1 commit into
Open
transition: don't treat the 'GO / NO-GO' heading as a NO-GO verdict#195selimdev00 wants to merge 1 commit into
selimdev00 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
validateReadinessflags a readiness report as NO-GO with a bare substring test:But the conventional readiness report heading is "GO / NO-GO Decision" - which literally contains
NO-GO. (bmalph itself classifies a readiness artifact by exactly that heading:specs-index.tsmatches/^##\s+GO\s*\/\s*NO-GO/m.) So a perfectly GO-ready report is flagged E1 andbmalph implementis blocked unless you pass--force. Prose like "this isn't a no-go" trips it too.Fix
Match a NO-GO verdict but skip the
GO / NO-GOlabel, via a negative lookbehind for the leadingGO /:## GO / NO-GO Decision+Decision: GO-> not flagged (was: wrongly flagged)## GO / NO-GO Decision+Decision: NO-GO-> still flaggedStatus: NO-GO/NO GO/No-Go/NOGO-> still flagged (existing tests unchanged)Node/V8 supports variable-length lookbehind, so this needs no engine flags.
Tests
Added cases for the GO-ready report with the heading (no issue), a NO-GO verdict alongside the heading (still E1), and the compact
GO/NO-GOlabel. All existingvalidateReadinesstests still pass (49 total in the file).