fix(parser): report unclosed multiline comments - #924
Merged
Conversation
michaeloliverx
force-pushed
the
fix-parser
branch
2 times, most recently
from
July 21, 2026 11:25
86d1709 to
8d19ca9
Compare
Laupetin
force-pushed
the
fix-parser
branch
3 times, most recently
from
July 23, 2026 16:27
97a681a to
1aae804
Compare
Laupetin
approved these changes
Jul 23, 2026
Laupetin
left a comment
Laupetin
left a comment
Owner
There was a problem hiding this comment.
Thank you very much :) Just changed the variable names a bit since i got confused and hurt myself trying to merge the two variables that should not be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OAT builds this project:
https://github.com/reaaLx/iw3styledmenu/tree/master
It prints:
The menu has matching braces. The real fault lies in
ui_mp/cac_loadout.inc, which ends with/*but has no*/. This makes OAT treat the rest of the menu, including its closing braces, as a comment.This fix makes OAT track where each block comment starts. If OAT reaches EOF before
*/, it now prints the right file and line:The new test covers an unclosed block comment at EOF.
Relates to #160