Updated to reflect simplified TLS configuration #277
Merged
Conversation
MadelineAu
requested review from
Gajesh2007,
MC1823315,
NimaVaziri,
antojoseph,
mmurrs and
solimander
as code owners
mmurrs
reviewed
Apr 24, 2026
|
|
||
| ### Options | ||
|
|
||
| `--private-key 0x...` (string) |
Contributor
There was a problem hiding this comment.
We should really encourage users to just put the private key in the environment variable as best security practice. May be worth making an update to the CLI so this is the only path rather than plaintext.
Collaborator
Author
There was a problem hiding this comment.
Agree we shouldn't be enabling poor security practices. I'll flag to the eng team and add a warning in docs until this change is made.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mmurrs
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other updates from Layr-Labs/ecloud#87