feat: eigencompute#1611
Open
0xrajath wants to merge 2 commits into
Open
Conversation
**Motivation:** We need a ComputeRegistry for AVSs to register their operator set to EigenCompute so that the EigenCompute operator can register that to that AVS operator set and pull the latest release from ReleaseManager. Additionally the AVS needs to sign a Terms of Service before they can register for EigenCompute https://lucid.app/lucidchart/26f35348-cd23-47d4-b848-0f4f9335c719/edit?invitationId=inv_8dc26eb0-772d-4018-884f-f54d46d3ee0f&page=0_0# **Modifications:** * ComputeRegistry core contract, interface and storage. * Terms of Service is signed through a EIP-712 signature. * Unit tests. * Updated Bindings **Result:** ComputeRegistry
There was a problem hiding this comment.
Pull Request Overview
This PR implements a ComputeRegistry for the EigenCompute system, enabling AVSs to register their operator sets for compute services with EIP-712 Terms of Service signature requirements.
- Introduces a new ComputeRegistry contract with registration/deregistration functionality
- Implements EIP-712 signature verification for Terms of Service acceptance
- Adds comprehensive unit tests covering all registration validation and error scenarios
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/unit/ComputeRegistryUnit.t.sol | Complete test suite for ComputeRegistry functionality including registration, deregistration, and validation tests |
| src/test/mocks/ReleaseManagerMock.sol | Mock implementation for testing release management functionality |
| src/test/mocks/KeyRegistrarMock.sol | Mock implementation for testing key registrar curve type validation |
| src/test/mocks/CrossChainRegistryMock.sol | Updated mock for testing cross-chain generation reservation validation |
| src/contracts/interfaces/IComputeRegistry.sol | Interface definition with comprehensive documentation for the ComputeRegistry contract |
| src/contracts/cloud/ComputeRegistryStorage.sol | Storage layout and immutable contract dependencies |
| src/contracts/cloud/ComputeRegistry.sol | Core implementation with registration validation and EIP-712 signature verification |
| pkg/bindings/IComputeRegistry/binding.go | Generated Go bindings for the interface |
| pkg/bindings/ComputeRegistryStorage/binding.go | Generated Go bindings for storage contract |
| pkg/bindings/ComputeRegistry/binding.go | Generated Go bindings for main contract |
Comments suppressed due to low confidence (1)
src/contracts/cloud/ComputeRegistry.sol:1
- The deregisterFromCompute function removes the operator set from registration but does not clear the stored TOS signature. This leaves stale data that could be misleading when querying getOperatorSetTosSignature for a deregistered operator set.
// SPDX-License-Identifier: BUSL-1.1
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
**Motivation:** ComputeRegistry contract documentation **Modifications:** * ComputeRegistry contract documentation * Small interface fixes **Result:** Contract clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need a ComputeRegistry for AVSs to register their operator set to EigenCompute so that the EigenCompute operator can register that to that AVS operator set and pull the latest release from ReleaseManager.
Additionally the AVS needs to sign a Terms of Service before they can register for EigenCompute
https://lucid.app/lucidchart/26f35348-cd23-47d4-b848-0f4f9335c719/edit?invitationId=inv_8dc26eb0-772d-4018-884f-f54d46d3ee0f&page=0_0#
Modifications:
Result:
EigenCompute Registration