Repository navigation
fix(player): preserve true start after first-frame bootstrap - #67
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
This PR was claimed |
Owner
Author
|
This PR's claim 6260289434 was released at 49ff662 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the Continuum protocol at 9aea333.
Summary
The silent first-frame bootstrap could leave first Play around one second into a video, audibly skipping its opening. Keep the clean paused preview, but restore resolved clip A on first Play before unmuting and starting playback. This applies to both watch and editor.
Changes
docs/player.md.The retained preview approach avoids a paused rewind that could restore YouTube's cued thumbnail. YouTube seeks remain approximate; actual audible content and mobile user activation require manual verification.
Verification
pnpm check: passed, zero errors/warnings.pnpm lint: passed.pnpm test:clip: 30 passed.pnpm test:share-url: 24 passed.pnpm test:metadata: 18 passed.pnpm build: passed.pnpm test:browser: 36 passed (28 Chromium, 8 WebKit)./tmp/youloop-67-startup-proof.logand/tmp/youloop-67-startup-preview.spec.ts.Test lifetime: retain first-Play assertions in the existing editor/provider journey and the signed-range journey permanently. They catch silent loss of opening content and signed-start regressions through the real adapter, which numeric Node tests miss. No new test cases, tags, or routine executions remain; existing resize and signed URL/history coverage stays in those journeys. The broad live/advisory suite was not run.
Manual verification after the preview deployment is Ready
Use the latest Vercel Preview linked below, not production before merge:
Manual audio and physical-device checks remain pending. Mocked Chromium/WebKit do not prove audible content or real-device autoplay behavior. Leave merge to the maintainer.