INTERMEDIO - feature/#73-Funcionalidad-reset-password-en-Editar-Usuario-a-mock-server#75
Open
manugallegob wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the reset password functionality for editing a user on a mock server, adding new UI components, API integrations, and mutation hooks.
- Introduces a new react-query mutation hook (useUpdateUserPasswordMutation) for updating a user's password.
- Updates related UI components to trigger a confirmation dialog and display success/error alerts upon password reset.
- Adds API integration and exports new alert components and dialog components.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/users/edit-reset-password/edit-reset-password.query.hook.ts | Adds a mutation hook for password update. |
| src/modules/users/edit-reset-password/edit-reset-password.pod.tsx | Passes user ID prop to the reset password component. |
| src/modules/users/edit-reset-password/edit-reset-password.component.tsx | Implements UI logic and integrates confirmation dialog and alert components. |
| src/modules/users/edit-reset-password/components/index.ts | Updates exports to include new alert component. |
| src/modules/users/edit-reset-password/components/confirm-reset-dialog.component.tsx | Modifies the reset dialog to use the onConfirm handler and displays a spinner. |
| src/modules/users/edit-reset-password/components/alerts-reset-password.componet.tsx | Introduces new success/error alert components. |
| src/modules/users/edit-reset-password/api/edit-reset-password.api.ts | Adds API call for updating the user password. |
Comments suppressed due to low confidence (1)
src/modules/users/edit-reset-password/edit-reset-password.query.hook.ts:9
- The hook is named 'useUpdateUserPasswordMutation' but returns an object with the property 'savePassword'. Consider renaming 'savePassword' to 'updatePassword' (or vice versa) for consistency.
interface UseSavePasswordMutationResult {
| @@ -0,0 +1,25 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
The file name 'alerts-reset-password.componet.tsx' appears to contain a typographical error. Consider renaming it to 'alerts-reset-password.component.tsx'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.