Esta PR implementa la pantalla para editar datos generales.#78
Open
rojasadrian012 wants to merge 6 commits intomainfrom
Open
Esta PR implementa la pantalla para editar datos generales.#78rojasadrian012 wants to merge 6 commits intomainfrom
rojasadrian012 wants to merge 6 commits intomainfrom
Conversation
…and type definitions
…xecution period type and enhance input handling
There was a problem hiding this comment.
Pull Request Overview
This PR implements the "Editar Datos Generales" screen, providing UI components, styles, and integration with API endpoints and the mock server.
- Introduces a new view-model with related utility functions and mappers.
- Implements several new components for handling form sections, date pickers, and actions.
- Updates API endpoints and mock server repositories for expediente data retrieval.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/expedientes/editar-datos-generales/hook/index.ts | Exports custom hook for formik fields. |
| src/modules/expedientes/editar-datos-generales/editar-datos-generales.vm.ts | Defines the view-model interfaces and default data. |
| src/modules/expedientes/editar-datos-generales/editar-datos-generales.styles.ts | Adds styling for the form container. |
| src/modules/expedientes/editar-datos-generales/editar-datos-generales.pod.tsx | Introduces the container component that fetches data and renders the editing form. |
| src/modules/expedientes/editar-datos-generales/editar-datos-generales.mappers.ts | Provides mapping from expediente models to general data formats. |
| src/modules/expedientes/editar-datos-generales/editar-datos-generales.component.tsx | Implements the main editing form leveraging Formik and MUI components. |
| src/modules/expedientes/editar-datos-generales/constans/* | Exports constant arrays used in form selectors. |
| src/modules/expedientes/editar-datos-generales/components/* | Adds form sections, styling, and action components for the screen. |
| src/modules/expedientes/editar-datos-generales/api/* | Implements API integrations for expediente retrieval. |
| package.json | Updates dependencies to support new date pickers and type definitions. |
| mock-server/* | Updates mock API endpoints and repository functions to support expediente retrieval. |
| export const stackItemRow = (theme: Theme) => css` | ||
| display: flex; | ||
| flex-direction: row; | ||
| with: 100%; |
There was a problem hiding this comment.
There appears to be a typo in the CSS property. Replace 'with: 100%;' with 'width: 100%;' to ensure the expected styling is applied.
Suggested change
| with: 100%; | |
| width: 100%; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #48