Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out - #1306
Closed
jlnav wants to merge 30 commits into
Closed
Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out#1306jlnav wants to merge 30 commits into
jlnav wants to merge 30 commits into
Conversation
jlnav
changed the title
jlnav
changed the title
jlnav
marked this pull request as ready for review
May 17, 2024 16:19
…list is actually populated
… renamed for clarity in 2.0
Minor cleanup
capitalization
This reverts commit 939f868.
fixing a capitalization
Release/v 1.6.0
Member
Author
|
zero_resource_workers removed in another branch. Other features' removals will be addressed separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've worried for a long time that it's impossible to remove things without inconveniencing/warning users manually. For features/capabilities we'd like to remove or dramatically change, we ought to raise DeprecationWarnings for those features, warning of exactly when to expect changes.
I think nowadays users seem to be more likely to request new features, changes, or cleanups at the cost of complete backward compatibility. Plus, thankfully, we're not deleting old releases; I wouldn't mind releasing patches to old releases if requested, similarly to how Python 3.9, 3.10, etc. still get patches.
So based on a handful of conversations, I'll start by proposing the deprecation of those features listed in the title.