Skip to content

Update finalize to meet standard - #1582

Merged
shuds13 merged 28 commits into
experimental/jlnav_plus_shuds_asktellfrom
feature/update_finalize
Oct 2, 2025
Merged

Update finalize to meet standard#1582
shuds13 merged 28 commits into
experimental/jlnav_plus_shuds_asktellfrom
feature/update_finalize

Conversation

@shuds13

@shuds13 shuds13 commented Aug 21, 2025

Copy link
Copy Markdown
Member
  • Remove finalize return and argument
  • Add get/export_data function.
  • Ensure finalize finishes any comms with remote process (and shuts down) so export simply returns data.
  • Add user_fields option to export to return H with user fields (e.g., beam_length)
  • Add tests for new unmapping function + finalize/export.
  • Rename generator_standard to gest_api

@jlnav

jlnav commented Aug 21, 2025

Copy link
Copy Markdown
Member

Good catch. Thankfully I believe I adjusted the runner recently to not suggest/ingest data from finalize anymore,

        tag, Work, H_in = self.ps.send_recv(H_out)  # evaluate the initial sample
        final_H_out = self._start_generator_loop(tag, Work, H_in)
        self.gen.finalize()

but the signature obviously was still incorrect

@codecov

codecov Bot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.02703% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.79%. Comparing base (6b54991) to head (ad54abd).
⚠️ Report is 193 commits behind head on experimental/jlnav_plus_shuds_asktell.

Files with missing lines Patch % Lines
libensemble/generators.py 72.22% 10 Missing ⚠️
libensemble/gen_classes/aposmm.py 76.92% 1 Missing and 2 partials ⚠️
libensemble/gen_funcs/aposmm_localopt_support.py 33.33% 2 Missing ⚠️
libensemble/utils/misc.py 90.47% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (6b54991) and HEAD (ad54abd). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (6b54991) HEAD (ad54abd)
15 10
Additional details and impacted files
@@                            Coverage Diff                             @@
##           experimental/jlnav_plus_shuds_asktell    #1582       +/-   ##
==========================================================================
- Coverage                                  89.95%   78.79%   -11.17%     
==========================================================================
  Files                                         79       79               
  Lines                                       7915     7964       +49     
  Branches                                    1176     1192       +16     
==========================================================================
- Hits                                        7120     6275      -845     
- Misses                                       615     1472      +857     
- Partials                                     180      217       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shuds13
shuds13 requested a review from jmlarson1 October 1, 2025 20:23
Comment thread libensemble/gen_classes/aposmm.py Outdated
@shuds13
shuds13 merged commit a383dc0 into experimental/jlnav_plus_shuds_asktell Oct 2, 2025
12 of 14 checks passed
@shuds13
shuds13 deleted the feature/update_finalize branch October 2, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants