Better parameterization of APOSMM class, plus docstring by jlnav · Pull Request #1583 · Libensemble/libensemble

jlnav · 2025-08-22T14:56:36Z

No description provided.

…documenting, and so we don't have to check the existence of settings in kwargso

codecov · 2025-08-22T15:05:38Z

Codecov Report

❌ Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.73%. Comparing base (a383dc0) to head (c040721).
⚠️ Report is 238 commits behind head on experimental/jlnav_plus_shuds_asktell.

Files with missing lines	Patch %	Lines
libensemble/gen_classes/aposmm.py	77.27%	2 Missing and 3 partials ⚠️
libensemble/gen_funcs/aposmm_localopt_support.py	82.60%	2 Missing and 2 partials ⚠️
libensemble/gen_funcs/persistent_aposmm.py	0.00%	0 Missing and 1 partial ⚠️
libensemble/gen_funcs/persistent_ax_multitask.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                            Coverage Diff                            @@
##           experimental/jlnav_plus_shuds_asktell    #1583      +/-   ##
=========================================================================
- Coverage                                  78.75%   78.73%   -0.03%     
=========================================================================
  Files                                         79       79              
  Lines                                       7983     7993      +10     
  Branches                                    1195     1196       +1     
=========================================================================
+ Hits                                        6287     6293       +6     
- Misses                                      1477     1481       +4     
  Partials                                     219      219

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shuds13 · 2025-08-22T15:32:12Z

+        gen_specs["user"]["xtol_abs"] = xtol_abs
+        gen_specs["user"]["ftol_abs"] = ftol_abs
+        gen_specs["user"]["dist_to_bound_multiple"] = dist_to_bound_multiple
+        gen_specs["user"]["max_active_runs"] = max_active_runs


FIELDS = [ "initial_sample_size", "sample_points", "localopt_method", "rk_const", "xtol_abs", "ftol_abs", "dist_to_bound_multiple", "max_active_runs", ] u = gen_specs.setdefault("user", {}) temp = {} for k in FIELDS: val = locals().get(k) if val is not None: temp[k] = val u.update(temp)

or separate required v optional

Maybe this works but grabbing values from locals() to prevent redundancy just looks odd to me. I can still implement this.

Its just a way to convert a string to a function name. Better than typing them all out right?

… with loop over fields and grabbing the value from locals, as suggested by shuds

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.35.7 to 1.36.2. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.35.7...v1.36.2) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.36.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…evelop/crate-ci/typos-1.36.2 Bump crate-ci/typos from 1.35.7 to 1.36.2

Bumps the python-updates group with 3 updates in the / directory: [pytest](https://github.com/pytest-dev/pytest), [pytest-cov](https://github.com/pytest-dev/pytest-cov) and [globus-compute-sdk](https://github.com/globus/globus-compute). Updates `pytest` from 8.4.1 to 8.4.2 - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.4.1...8.4.2) Updates `pytest-cov` from 6.2.1 to 7.0.0 - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v6.2.1...v7.0.0) Updates `globus-compute-sdk` from 3.12.0 to 3.13.0 - [Release notes](https://github.com/globus/globus-compute/releases) - [Changelog](https://github.com/globus/globus-compute/blob/main/docs/changelog.rst) - [Commits](globus/globus-compute@3.12.0...3.13.0) --- updated-dependencies: - dependency-name: pytest dependency-version: 8.4.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-updates - dependency-name: pytest-cov dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-updates - dependency-name: globus-compute-sdk dependency-version: 3.13.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-updates ... Signed-off-by: dependabot[bot] <support@github.com>

…on-updates-a8a26ef096 Bump the python-updates group across 1 directory with 3 updates

Adding test for ibcdfo with jax

Black

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.36.2 to 1.36.3. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.36.2...v1.36.3) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.36.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the python-updates group with 2 updates in the / directory: [globus-compute-sdk](https://github.com/globus/globus-compute) and [anyio](https://github.com/agronholm/anyio). Updates `globus-compute-sdk` from 3.13.0 to 3.15.0 - [Release notes](https://github.com/globus/globus-compute/releases) - [Changelog](https://github.com/globus/globus-compute/blob/main/docs/changelog.rst) - [Commits](globus/globus-compute@3.13.0...3.15.0) Updates `anyio` from 4.10.0 to 4.11.0 - [Release notes](https://github.com/agronholm/anyio/releases) - [Changelog](https://github.com/agronholm/anyio/blob/master/docs/versionhistory.rst) - [Commits](agronholm/anyio@4.10.0...4.11.0) --- updated-dependencies: - dependency-name: globus-compute-sdk dependency-version: 3.15.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-updates - dependency-name: anyio dependency-version: 4.11.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-updates ... Signed-off-by: dependabot[bot] <support@github.com>

Updating IBCDFO branch

…evelop/crate-ci/typos-1.36.3 Bump crate-ci/typos from 1.36.2 to 1.36.3

…52850e7

…on-updates-ee952850e7 Bump the python-updates group across 1 directory with 2 updates

shuds13 · 2025-10-01T18:33:03Z

        self.VOCS = vocs

+        gen_specs = {}
+        persis_info = {"1": np.random.default_rng(random_seed)}


why is this with key "1", I dont think we want that.

shuds13 · 2025-10-01T19:19:41Z

+        ftol_abs: float = 1e-6,
+        dist_to_bound_multiple: float = 0.5,
+        max_active_runs: int = 6,
+        random_seed: int = 1,


Should default be 0 or 1.

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.36.3 to 1.37.3. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.36.3...v1.37.3) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…evelop/crate-ci/typos-1.37.3 Bump crate-ci/typos from 1.36.3 to 1.37.3

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.37.3 to 1.38.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.37.3...v1.38.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.38.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the python-updates group with 3 updates: [matplotlib](https://github.com/matplotlib/matplotlib), [globus-compute-sdk](https://github.com/globus/globus-compute) and [rich](https://github.com/Textualize/rich). Updates `matplotlib` from 3.10.6 to 3.10.7 - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.10.6...v3.10.7) Updates `globus-compute-sdk` from 3.15.0 to 3.16.0 - [Release notes](https://github.com/globus/globus-compute/releases) - [Changelog](https://github.com/globus/globus-compute/blob/main/docs/changelog.rst) - [Commits](globus/globus-compute@3.15.0...3.16.0) Updates `rich` from 14.1.0 to 14.2.0 - [Release notes](https://github.com/Textualize/rich/releases) - [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md) - [Commits](Textualize/rich@v14.1.0...v14.2.0) --- updated-dependencies: - dependency-name: matplotlib dependency-version: 3.10.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-updates - dependency-name: globus-compute-sdk dependency-version: 3.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-updates - dependency-name: rich dependency-version: 14.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-updates ... Signed-off-by: dependabot[bot] <support@github.com>

…evelop/crate-ci/typos-1.38.1 Bump crate-ci/typos from 1.37.3 to 1.38.1

…on-updates-345d75facd Bump the python-updates group with 3 updates

…smm_fixes

…cts with using variables_mapping later on

shuds13 · 2025-10-23T20:05:32Z

+            rk_const = 0.5 * ((gamma(1 + (self.n / 2)) * 5) ** (1 / self.n)) / sqrt(pi)
+
        gen_specs["user"] = {}
+        gen_specs["user"]["lb"] = np.array([vocs.variables[i].domain[0] for i in vocs.variables])


this is set below

shuds13 · 2025-10-23T20:05:48Z

+            if val is not None:
+                gen_specs["user"][k] = val
+
+        gen_specs["persis_in"] = ["x", "f", "local_pt", "sim_id", "sim_ended", "x_on_cube", "local_min"]


this is set below without local_min

shuds13 · 2025-10-23T20:06:05Z

+        persis_info = {}
+        libE_info = {}
        gen_specs["gen_f"] = aposmm
+        self.n = len(list(self.VOCS.variables.keys()))


I removed self.n

jmlarson1 · 2025-10-28T19:54:50Z

+        What fraction of the distance to the nearest boundary should the initial
+        step size be in localopt runs.
+
+    max_active_runs: int = 6


Shouldn't be 6

jmlarson1 · 2025-10-28T19:55:21Z

+    History: npt.NDArray = []
+        An optional history of previously evaluated points.
+
+    initial_sample_size: int = 100


Should be dependent on n or possibly nfmax

So it's dependent on the problem dimension... as in it's simply a multiple of it, right?

I'm making it a required field as we discussed - I'm assuming users will eyeball a good stating size?

…posmm class - and rearrange to be higher in the docstring and signature

jlnav added 3 commits August 21, 2025 15:48

starting to populate the APOSMM class with common kwargs, for better …

c8d6a82

…documenting, and so we don't have to check the existence of settings in kwargso

small fixes

1dce059

docstring for APOSMM class

77845a0

shuds13 reviewed Aug 22, 2025

View reviewed changes

jlnav added 2 commits August 22, 2025 13:37

evaluate an APOSMM with only VOCS passed in

2635236

replace completely-typed out gen_specs['user'] update from parameters…

4e73c93

… with loop over fields and grabbing the value from locals, as suggested by shuds

jlnav requested a review from shuds13 August 26, 2025 19:27

jlnav and others added 22 commits August 27, 2025 08:08

coverage adjusts

4357173

Merge pull request #1589 from Libensemble/dependabot/github_actions/d…

4c10f40

…evelop/crate-ci/typos-1.36.2 Bump crate-ci/typos from 1.35.7 to 1.36.2

Adding test for ibcdfo with jax

04485be

clenaup

df4a395

Starting a manifold sampling example

e6769bc

Merge pull request #1592 from Libensemble/dependabot/pip/develop/pyth…

ad42858

…on-updates-a8a26ef096 Bump the python-updates group across 1 directory with 3 updates

Fixing ibcdfo tests

0fcc9b5

black

3fe6376

Black

00b6fc0

Updated IBCDFO branch

63c082a

reverting

5d0ae3d

Updated IBCDFO branch

334dc8d

Removing unused def

756a854

Merge pull request #1591 from Libensemble/updating_ibcdfo_example

92e65d3

Adding test for ibcdfo with jax

Merge pull request #1593 from Libensemble/formatting/black_2025_09_17

38f3fcb

Black

Updating IBCDFO branch

6c0df1d

Merge pull request #1599 from Libensemble/update_msp_branch

0920ec1

Updating IBCDFO branch

Merge pull request #1597 from Libensemble/dependabot/github_actions/d…

f8e977d

…evelop/crate-ci/typos-1.36.3 Bump crate-ci/typos from 1.36.2 to 1.36.3

jmlarson1 added 2 commits September 30, 2025 14:43

Merge branch 'develop' into dependabot/pip/develop/python-updates-ee9…

7858075

…52850e7

Merge pull request #1598 from Libensemble/dependabot/pip/develop/pyth…

ec7add0

…on-updates-ee952850e7 Bump the python-updates group across 1 directory with 2 updates

shuds13 reviewed Oct 1, 2025

View reviewed changes

dependabot Bot and others added 14 commits October 6, 2025 19:06

typo

b7b539f

typo

95dd275

typo

1a68569

Merge pull request #1601 from Libensemble/dependabot/github_actions/d…

a565a4c

…evelop/crate-ci/typos-1.37.3 Bump crate-ci/typos from 1.36.3 to 1.37.3

Merge pull request #1602 from Libensemble/dependabot/github_actions/d…

c8bee35

…evelop/crate-ci/typos-1.38.1 Bump crate-ci/typos from 1.37.3 to 1.38.1

Merge pull request #1603 from Libensemble/dependabot/pip/develop/pyth…

beb9b88

…on-updates-345d75facd Bump the python-updates group with 3 updates

Merge branch 'experimental/jlnav_plus_shuds_asktell' into asktell/apo…

1353363

…smm_fixes

Merge branch 'develop' into asktell/aposmm_fixes

bb26e05

this specific gen_specs['out'] assignment no longer needed, as confli…

948c88b

…cts with using variables_mapping later on

adjust for finalize and export; plus now variables_mapping is required

047673d

don't need persis_info declared like this

b681398

jlnav requested a review from shuds13 October 23, 2025 19:45

shuds13 reviewed Oct 23, 2025

View reviewed changes

fixes and refactors as suggested by shuds - *works on multistage lpa*

b828cb4

jlnav requested a review from shuds13 October 24, 2025 15:23

jmlarson1 reviewed Oct 28, 2025

View reviewed changes

make initial_sample_size and max_active_runs required arguments for a…

c040721

…posmm class - and rearrange to be higher in the docstring and signature

shuds13 approved these changes Oct 29, 2025

View reviewed changes

jlnav merged commit cd776a1 into experimental/jlnav_plus_shuds_asktell Oct 29, 2025
11 of 12 checks passed

jlnav deleted the asktell/aposmm_fixes branch October 29, 2025 19:15

Uh oh!

Conversation

jlnav commented Aug 22, 2025

Uh oh!

codecov Bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shuds13 Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Aug 22, 2025 •

edited

Loading

shuds13 Oct 1, 2025 •

edited

Loading