Populate gen_specs from generator - #1594
Closed
shuds13 wants to merge 1 commit into
Closed
Conversation
Optimas nlopt getting errors. sim_ended prep_fields hack not needed in libE test - not sure with Optimas. Is population of gen_specs from generator needed with Optimas or external gens Should not be as worked before but this has a trial method to get it from ExternalGenerator.
Base automatically changed from
feature/update_finalize
to
experimental/jlnav_plus_shuds_asktell
October 2, 2025 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is experimenting.
Do not pull this one in, I will create a new PR after update_finalize is merged as this is different subject.
Optimas nlopt getting errors.
sim_ended prep_fields hack not needed in libE test - not sure with Optimas.
Is population of gen_specs from generator needed with Optimas or external gens
Should not be as worked before but this has a trial method to get it from ExternalGenerator.
Update: With further thought, I may abandon this. The internal gen_specs is for the internal generator in case of using a proxy gen (ie. it is for the APOSMM running on a process) - which receives converted values (x, f or fvec). Whereas the external gen_specs in libE should really be determined by vocs entries. So they probably end up being the same. But in Optimas, for example, they are set by vocs and you dont want, say x or fvec, getting added (when it should be using beam_length or a series of vals).
Setting from VOCS, as the gen has been given vocs, in theory can get from gen - and Optimas is doing this (trials are set from generator get_gen_specs) - but would need to have stored original inputs.
Superceded by #1620 (which sets from
vocs).