Remove automapping - #1622
Merged
shuds13 merged 13 commits intoNov 25, 2025
Merged
Conversation
Member
Author
|
✔️ test_xopt_EI.py test_asktell_sampling.py split to two tests and re-written. Now works What other tests are there? |
* Split tests libEnsemble and external generators * Have an vocs generator that uses arrays * Array generator disabled as requires gest-api update.
jlnav
approved these changes
Nov 25, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## examples/xopt_generators #1622 +/- ##
===========================================================
Coverage ? 78.41%
===========================================================
Files ? 81
Lines ? 8099
Branches ? 1220
===========================================================
Hits ? 6351
Misses ? 1525
Partials ? 223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with removing automapping.
xopt test runs with this change.
We should run all tests and see what breaks.
Do we need to keep auto-mapping, in an optional sense, or modify it.
If remove will have to update unit tests.
Ive also added
gest_api_wrappersim func so xopt/gest-api style sims can be used directly