Repository navigation
🧹 refactor: Clear Raw-Color, Unknown-Class and Arbitrary-Value Suppressions - #16829
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f4df6364f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --text-3xs: 0.625rem; | ||
| --text-2xs: 0.6875rem; | ||
| --text-1xs: 0.71875rem; | ||
| --text-1sm: 0.8125rem; |
There was a problem hiding this comment.
Route compact font sizes through the theme registry
These new @theme inline entries compile the sizes directly into the generated utilities, bypassing the shared --theme-text-* properties and typed registry used by the rest of the type scale. Consequently, when a custom or high-contrast theme deliberately changes its typography, labels using text-3xs through text-1sm remain fixed and become inconsistent; define these reusable scale steps in the shared versioned theme registry with defaults that preserve the current measurements.
AGENTS.md reference: AGENTS.md:L144-L151
Useful? React with 👍 / 👎.
| .shadow-stroke, | ||
| .avatar-stroke { |
There was a problem hiding this comment.
Replace the stroke alias with a semantic avatar role
The new avatar-stroke alias still draws its edge using the fixed black and white values later in this rule, so renaming the class only hides the raw-color usage from the component lint. In a custom or high-contrast theme, endpoint avatars therefore ignore the theme's avatar-edge choice; use the existing semantic avatar-edge token or add an appropriate versioned role whose default reproduces this stroke.
AGENTS.md reference: AGENTS.md:L144-L151
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Deferred to berry-13#287. The avatar-stroke rule is no longer part of this diff (dev already carries it), so this change adds no raw rgba.
1f4df63 to
ad60b86
Compare
Summary
The design lint carried suppressions for raw colors, unknown classes and arbitrary values in the Auth, Nav, Endpoints and chat-menu folders. Most were one-offs:
shadow-strokeread as a color name, two classes (align-end,account-settings-popover) that no stylesheet defines,border-r-[1px], a transition list the generictransition-allcovers, and px font sizes (10, 11, 11.5, 13) for shortcut hints and badges.shadow-strokegets anavatar-strokealias with the same rules, the dead classes are removed,border-r-[1px]becomesborder-r, and the px sizes become fixed type-scale steps declared inclient/src/style.css(text-3xs,text-2xs,text-1xs,text-1sm; the 12px sites taketext-xswithleading-normalso the line height stays what the arbitrary size inherited). Raw-color and unknown-class suppressions in these folders go to 0, and arbitrary-value suppressions fall from 19 to 1; the remaining one is the keyboard-shortcuts dialog title, whosetext-[16px]would only trade one suppression for ano-restyleone onDialogTitle.The default theme is unchanged: before and after captures of the account menu, Help submenu and keyboard shortcuts dialog, light and dark, are pixel-identical.
Type of change
Testing
Tested environments/configuration: Chromium via Playwright against
lcdev servers, default theme, light and dark, reduced motion on.Automated tests:
npx eslinton the touched files: only the pre-existingno-restylebacklog remainsnpm run lint:design:prunerun;npm run static-checks -- --against origin/devpassesScreenshots / recordings
Pixel diff of 6 captures between dev and this branch is empty; the shortcuts dialog follows.
Checklist