Skip to content

🧹 refactor: Clear Raw-Color, Unknown-Class and Arbitrary-Value Suppressions - #16829

Merged
berry-13 merged 3 commits into
devfrom
berry-13/supp-auth-nav-1
Oct 7, 2026
Merged

berry-13 merged 3 commits into
devfrom
berry-13/supp-auth-nav-1

Conversation

@berry-13

@berry-13 berry-13 commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The design lint carried suppressions for raw colors, unknown classes and arbitrary values in the Auth, Nav, Endpoints and chat-menu folders. Most were one-offs: shadow-stroke read as a color name, two classes (align-end, account-settings-popover) that no stylesheet defines, border-r-[1px], a transition list the generic transition-all covers, and px font sizes (10, 11, 11.5, 13) for shortcut hints and badges.

shadow-stroke gets an avatar-stroke alias with the same rules, the dead classes are removed, border-r-[1px] becomes border-r, and the px sizes become fixed type-scale steps declared in client/src/style.css (text-3xs, text-2xs, text-1xs, text-1sm; the 12px sites take text-xs with leading-normal so the line height stays what the arbitrary size inherited). Raw-color and unknown-class suppressions in these folders go to 0, and arbitrary-value suppressions fall from 19 to 1; the remaining one is the keyboard-shortcuts dialog title, whose text-[16px] would only trade one suppression for a no-restyle one on DialogTitle.

The default theme is unchanged: before and after captures of the account menu, Help submenu and keyboard shortcuts dialog, light and dark, are pixel-identical.

Type of change

  • Refactor

Testing

Tested environments/configuration: Chromium via Playwright against lc dev servers, default theme, light and dark, reduced motion on.

Automated tests:

  • npx eslint on the touched files: only the pre-existing no-restyle backlog remains
  • npm run lint:design:prune run; npm run static-checks -- --against origin/dev passes
  • Not run: unit tests, since only class names changed

Screenshots / recordings

Pixel diff of 6 captures between dev and this branch is empty; the shortcuts dialog follows.

Checklist

  • I reviewed my own changes
  • The change does not introduce new warnings or errors

Keyboard shortcuts dialog, light

Copilot AI balanced review requested due to automatic review settings October 6, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T14:24:46.286516Z ad60b86 New commits
🔒 Security Review ✅ Completed 2026-10-06T14:34:55.017102Z 1f4df63 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f4df6364f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread client/src/style.css Outdated
Comment on lines +18 to +21
--text-3xs: 0.625rem;
--text-2xs: 0.6875rem;
--text-1xs: 0.71875rem;
--text-1sm: 0.8125rem;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route compact font sizes through the theme registry

These new @theme inline entries compile the sizes directly into the generated utilities, bypassing the shared --theme-text-* properties and typed registry used by the rest of the type scale. Consequently, when a custom or high-contrast theme deliberately changes its typography, labels using text-3xs through text-1sm remain fixed and become inconsistent; define these reusable scale steps in the shared versioned theme registry with defaults that preserve the current measurements.

AGENTS.md reference: AGENTS.md:L144-L151

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ad60b86: the interim @theme block is gone from style.css, and the sites use the registry steps from #16827 (13px is text-1xs; the 11.5px sites keep their arbitrary value and suppression).

Comment thread client/src/style.css Outdated
Comment on lines +1573 to +1574
.shadow-stroke,
.avatar-stroke {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the stroke alias with a semantic avatar role

The new avatar-stroke alias still draws its edge using the fixed black and white values later in this rule, so renaming the class only hides the raw-color usage from the component lint. In a custom or high-contrast theme, endpoint avatars therefore ignore the theme's avatar-edge choice; use the existing semantic avatar-edge token or add an appropriate versioned role whose default reproduces this stroke.

AGENTS.md reference: AGENTS.md:L144-L151

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to berry-13#287. The avatar-stroke rule is no longer part of this diff (dev already carries it), so this change adds no raw rgba.

@berry-13
berry-13 force-pushed the berry-13/supp-auth-nav-1 branch from 1f4df63 to ad60b86 Compare October 7, 2026 14:22
@berry-13
berry-13 merged commit 8f681f3 into dev Oct 7, 2026
30 checks passed
@berry-13
berry-13 deleted the berry-13/supp-auth-nav-1 branch October 7, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants