Repository navigation
🎨 feat: Add Secondary Label Variant and Spinner Tone - #16837
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
berry-13
force-pushed
the
berry-13/primitives-label-spinner
branch
from
October 7, 2026 09:56
5c15961 to
ad12919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Label has a default (primary ink) and a
sectioneyebrow, so ten call sites that want the default label size, leading and weight in the secondary ink restyle the color with a class, and Spinner callers pintext-text-primaryortext-text-secondarythe same way. Both are color overrides of a primitive, which the design lint reports and a theme cannot reach.Label gains
variant="secondary"(default metrics, secondary ink) and Spinner gains atoneprop (current,primary,secondary). Both defaults reproduce today's rendering exactly: Label keepsdefault, Spinner keepscurrent, which adds no class.Type of change
Testing
Automated tests:
npx jest src/components/Label.spec.tsx src/svgs/__tests__/Spinner.spec.tsx(packages/client): 18 passedManual checks: the existing variants and the default Spinner output are unchanged by construction (additions only).
Risk / compatibility
None. New opt-in variants; no existing call site changes.
Checklist