Repository navigation
🎛️ feat: Add Quiet and Message Action Button Variants - #16839
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…r Button Variants
berry-13
force-pushed
the
berry-13/primitives-button
branch
from
October 7, 2026 10:03
fff2b61 to
1564476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Button call sites keep restyling the same few looks with classes: a quiet icon or text action in the secondary ink, a small message action under a reply, a link-like text action in a list or footer, a carousel arrow on the fixed surface, and a compact toolbar action. Each restyle is a
shadcn/no-restylecolor or shape override that a theme cannot reach.This adds five Button variants,
quiet,message-action,inline-link,carousel-navandtoolbar, built from theme roles. Compound variants keep their own box at the default size so the default size's height and padding do not win the merge. Existing variants and sizes are untouched, so current rendering is unchanged.Type of change
Testing
Automated tests:
npx jest src/components/Button.spec.tsx(packages/client): 27 passedManual checks: additions only, no existing variant recipe changed.
Risk / compatibility
Edits the same cva region as the open Button PRs from the sign-in and regression lanes; it will be rebased after they merge.
Checklist