Skip to content

🎛️ feat: Add Quiet and Message Action Button Variants - #16839

Merged
berry-13 merged 1 commit into
devfrom
berry-13/primitives-button
Oct 7, 2026
Merged

berry-13 merged 1 commit into
devfrom
berry-13/primitives-button

Conversation

@berry-13

@berry-13 berry-13 commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Button call sites keep restyling the same few looks with classes: a quiet icon or text action in the secondary ink, a small message action under a reply, a link-like text action in a list or footer, a carousel arrow on the fixed surface, and a compact toolbar action. Each restyle is a shadcn/no-restyle color or shape override that a theme cannot reach.

This adds five Button variants, quiet, message-action, inline-link, carousel-nav and toolbar, built from theme roles. Compound variants keep their own box at the default size so the default size's height and padding do not win the merge. Existing variants and sizes are untouched, so current rendering is unchanged.

Type of change

  • Feature

Testing

Automated tests:

  • npx jest src/components/Button.spec.tsx (packages/client): 27 passed
  • eslint, prettier and sort-imports on the two touched files: clean

Manual checks: additions only, no existing variant recipe changed.

Risk / compatibility

Edits the same cva region as the open Button PRs from the sign-in and regression lanes; it will be rebased after they merge.

Checklist

  • I reviewed my own changes
  • Relevant tests have been added or updated
  • Existing relevant tests pass
  • The change does not introduce new warnings or errors
  • Required documentation PR: N/A

Copilot AI balanced review requested due to automatic review settings October 6, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T10:06:42.328697Z 1564476 New commits
🔒 Security Review ✅ Completed 2026-10-06T15:36:54.547721Z fff2b61 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codegraph-librechat codegraph-librechat Bot added the 🗺️ Chat Frontend codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9) label Oct 6, 2026
@berry-13
berry-13 force-pushed the berry-13/primitives-button branch from fff2b61 to 1564476 Compare October 7, 2026 10:03
@berry-13
berry-13 merged commit c3836de into dev Oct 7, 2026
43 checks passed
@berry-13
berry-13 deleted the berry-13/primitives-button branch October 7, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗺️ Chat Frontend codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants