🚢 fix: Pack Code Protocol Into Egress Gateway Image - #108
Merged
danny-avila merged 1 commit intoSep 5, 2026
Conversation
The egress-gateway container crash-loops on startup:
error: Cannot find module '../../packages/code/src/protocol'
from '/app/src/secure-startup.ts'
`service/src/egress-gateway.ts` imports `./secure-startup`, and
`service/src/secure-startup.ts` imports `../../packages/code/src/protocol`.
`service/Dockerfile.egress-gateway` copies `service/src` and `shared` but
never copies `packages/code/src`, so from `/app/src/…` the relative import
resolves to `/packages/code/src/protocol`, which is absent from the image.
The other service images (`Dockerfile.node`, `Dockerfile.worker`) already
`COPY packages/code/src /packages/code/src` next to `COPY shared /shared`;
this adds the same line to both the production and development stages of the
egress-gateway image, matching that convention.
Tested by building `service/Dockerfile.egress-gateway` and confirming the
container reaches its `/health` endpoint on 3190 instead of exiting.
Collaborator
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
changed the title
danny-avila
approved these changes
Sep 5, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The egress-gateway container crash-loops on startup:
service/src/egress-gateway.tsimports./secure-startup, andservice/src/secure-startup.tsimports../../packages/code/src/protocol.service/Dockerfile.egress-gatewaycopiesservice/srcandsharedbut never copiespackages/code/src, so from/app/src/…the relative import resolves to/packages/code/src/protocol, which is absent from the image.The other service images (
Dockerfile.node,Dockerfile.worker) alreadyCOPY packages/code/src /packages/code/srcnext toCOPY shared /shared; this adds the same line to both the production and development stages of the egress-gateway image, matching that convention.Tested by building
service/Dockerfile.egress-gatewayand confirming the container reaches its/healthendpoint on 3190 instead of exiting.