fix: isolate file deletion rate limits - #193
Merged
Merged
Conversation
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expired-file cleanup sends DELETE requests through the file-list limiter today. A cleanup burst can therefore exhaust interactive list/metadata capacity, and clients receive the misleading message
Too many file list requests.This change gives deletion traffic an independent Redis bucket, wires both supported DELETE routes to it, and returns structured retry guidance with
Retry-After.DELETE_LIMIT_WINDOWandDELETE_MAX_REQUESTSfall back to the existing fetch settings, preserving current defaults while allowing operators to tune deletion separately.Production trigger
During a multi-replica rollout in AP, expired-file cleanup produced repeated CodeAPI DELETE requests, 15-second client timeouts, and 429 responses reporting the fetch limiter. This patch isolates that traffic and makes the backpressure contract machine-readable. The companion LibreChat PR prevents replicas from initiating duplicate sweeps.
Verification
bun test src/middleware/limits.test.ts src/service/exec-timeout.test.ts(10 passed)git diff --check