Skip to content

Conversation

@kaixiong
Copy link
Member

Rant: As usual, Microsoft does its own thing.

References:

  • Documentation on Microsoft Learn (link)
  • Thread on CMake (link)

@hartwork
Copy link
Member

hartwork commented Feb 10, 2023

@kaixiong PS: On a side note we're saying goodbye to Visual Studio <2017 (at least in part) here. Fine in my book, but important to know.

@kaixiong
Copy link
Member Author

@hartwork I ported Libvisual to Win32 (writing the WaveIn input in the process) and have never tried to compile it on MSVC. Maybe I should try one of these days and see where the gaps are. Interestingly enough, MSVC is now ahead of both GCC and Clang in terms of the latest C++ standard support.

@hartwork
Copy link
Member

@kaixiong we can make the CI cover MSVC at some point.

@kaixiong kaixiong merged commit b4a110e into master Feb 10, 2023
@kaixiong kaixiong deleted the fix-msvc-cplusplus branch February 10, 2023 16:20
@kaixiong
Copy link
Member Author

kaixiong commented Feb 12, 2023

@kaixiong PS: On a side note we're saying goodbye to Visual Studio <2017 (at least in part) here. Fine in my book, but important to know.

@hartwork We already are, master requires C++20 to build.

@hartwork
Copy link
Member

@hartwork hartwork added this to the 0.5.0_alpha1 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants