Skip to content

Core (lv-tool): Apply 'override' and 'final' to classes. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaixiong merged 1 commit into from
Feb 13, 2023
Merged

Core (lv-tool): Apply 'override' and 'final' to classes. #270

kaixiong merged 1 commit into from
Feb 13, 2023

Conversation

@kaixiong
Copy link
Member

@kaixiong kaixiong commented Feb 10, 2023

  • Use final to prohibit subclassing where needed
  • Use override instead of virtual when overriding virtual methods or implementing pure virtual methods.

@kaixiong kaixiong self-assigned this Feb 10, 2023
@kaixiong kaixiong added this to the 0.5.0_alpha1 milestone Feb 10, 2023
@kaixiong kaixiong merged commit 91cf509 into master Feb 13, 2023
@kaixiong kaixiong deleted the c++11-override-final branch February 13, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaixiong kaixiong

Labels

enhancement

Projects

None yet

Milestone

0.5.0_alpha1

Development

Successfully merging this pull request may close these issues.

2 participants

@kaixiong