fix(components): give command steps the Run/Ran tense verb - #1006
Merged
Merged
Conversation
Command tool calls title themselves with the raw command, so rows in an
expanded activity group rendered bare shell text while reads and searches
already read as tense-verb sentences ("Read view.tsx", "Searched for …").
Command steps now prepend Run through the shared TOOL_VERB_FORMS map —
"Running" while the call is in flight, "Ran" once it lands — and the
group header's command count shares the same isCommandToolCall predicate
so the counted set and the labeled set cannot drift. Titles already
carrying a verb or an authored label ("Shell: cat x") keep their wording.
The shimmering verb is itself the running signal, so an in-flight row
with a tense verb no longer carries the trailing spinner; verb-less
running rows keep it.
Model: swe-2-high
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sed -n '1,240p' …), so rows in an expanded activity group rendered bare shell text while reads and searches already read as tense-verb sentences ("Read view.tsx", "Searched for …"). Command steps now prependRunthrough the sharedTOOL_VERB_FORMSmap —Runningwhile the call is in flight,Ranonce it lands.isCommandToolCallpredicate (execute/bashkinds, plus any kind that actually carried terminal I/O), so the counted set and the labeled set cannot drift.Test plan
tests/agent-activity-row.test.tsx: expanded group assertsRan sed -n …,Running pnpm …, the kindless terminal-command case, untouchedShell:/Searched forshapes, and spinner presence only on the verb-less running row (25/25 pass)DesktopCommandStepsstory inAssistantTurnAlignment.stories.tsxfor visual review (screenshots attached in the authoring conversation)pnpm check:quick(oxlint, i18n, boundary guards) +@lody/componentstypecheck cleanGenerated with Devin