Skip to content

fix(components): give command steps the Run/Ran tense verb - #1006

Merged
wibus-wee merged 1 commit into
mainfrom
lody/c94bb267-5d6
Sep 26, 2026
Merged

wibus-wee merged 1 commit into
mainfrom
lody/c94bb267-5d6

Conversation

@wibus-wee

Copy link
Copy Markdown
Member

Summary

  • Command tool calls title themselves with the raw command (sed -n '1,240p' …), so rows in an expanded activity group rendered bare shell text while reads and searches already read as tense-verb sentences ("Read view.tsx", "Searched for …"). Command steps now prepend Run through the shared TOOL_VERB_FORMS map — Running while the call is in flight, Ran once it lands.
  • The group header's "Ran N commands" count and the row's verb prefix now share one isCommandToolCall predicate (execute/bash kinds, plus any kind that actually carried terminal I/O), so the counted set and the labeled set cannot drift.
  • Titles already carrying a verb, or authored labels that open with a capitalized non-verb word ("Shell: cat x"), keep their own wording — no doubled verbs.
  • The shimmering verb is itself the running signal, so an in-flight row with a tense verb drops the trailing spinner; verb-less running rows keep it.

Test plan

  • tests/agent-activity-row.test.tsx: expanded group asserts Ran sed -n …, Running pnpm …, the kindless terminal-command case, untouched Shell:/Searched for shapes, and spinner presence only on the verb-less running row (25/25 pass)
  • New DesktopCommandSteps story in AssistantTurnAlignment.stories.tsx for visual review (screenshots attached in the authoring conversation)
  • pnpm check:quick (oxlint, i18n, boundary guards) + @lody/components typecheck clean

Generated with Devin

Command tool calls title themselves with the raw command, so rows in an
expanded activity group rendered bare shell text while reads and searches
already read as tense-verb sentences ("Read view.tsx", "Searched for …").
Command steps now prepend Run through the shared TOOL_VERB_FORMS map —
"Running" while the call is in flight, "Ran" once it lands — and the
group header's command count shares the same isCommandToolCall predicate
so the counted set and the labeled set cannot drift. Titles already
carrying a verb or an authored label ("Shell: cat x") keep their wording.

The shimmering verb is itself the running signal, so an in-flight row
with a tense verb no longer carries the trailing spinner; verb-less
running rows keep it.

Model: swe-2-high

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@wibus-wee
wibus-wee merged commit dfdda1f into main Sep 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant