Fix Scala.js source map URI to point to GitHub; drop Scala 2.11#97
Merged
rossabaker merged 2 commits intoLog4s:masterfrom Mar 13, 2026
Merged
Fix Scala.js source map URI to point to GitHub; drop Scala 2.11#97rossabaker merged 2 commits intoLog4s:masterfrom
rossabaker merged 2 commits intoLog4s:masterfrom
Conversation
Contributor
|
There's going to be some toil here. Scala 2.11 hasn't been touched in 7 years, so I'd be fine dropping that in a minor version. |
Adds the `TypelevelScalaJSGitHubPlugin` to the build, which configures the Scala.js source map URI to point to GitHub. Sets the `-scalajs-mapSourceURI:` scalacOption so source-maps will point to GitHub, rather than a local file which will not exist for end users of log4s. ```sbt sbt:Log4s Root> show coreJS/scalacOptions --- [info] * -P:scalajs:mapSourceURI:file:/Users/hvanrijswijk1/ws/log4s/->https://raw.githubusercontent.com/Log4s/log4s/1f23b6c7cbc7400cce1f6670422461b62fa0211e/ ```
hugo-vrijswijk
force-pushed
the
scalajs-sourcemapUri
branch
from
8c4ff76 to
a068f23
Compare
Contributor
Author
Fine by me, I can remove it in the same PR and update to other more recent Scala versions at the same time |
hugo-vrijswijk
force-pushed
the
scalajs-sourcemapUri
branch
from
fd5373e to
4cdc3b9
Compare
hugo-vrijswijk
force-pushed
the
scalajs-sourcemapUri
branch
from
4cdc3b9 to
aeaf64f
Compare
rossabaker
changed the title
Contributor
|
I released 1.11.0-RC1 with this. If this scratched your itch, we can do a proper release next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
TypelevelScalaJSGitHubPluginto the build, which configures the Scala.js source map URI to point to GitHub. Sets the-scalajs-mapSourceURI:scalacOption so source-maps will point to GitHub, rather than a local file which will not exist for end users of log4s.