Conversation
I was not sure what each hook does, so proposing this PR to avoid ambiguity
Lucas-C
approved these changes
Jun 5, 2025
Contributor
Author
|
hmm, are these errors related? |
Owner
Yes, the I just added a commit on this PR branch to do that, and also add a sentence to clarify which hooks apply to text files, as you suggested. Note that it can also be seen by checking the presence of I'm merging this now, thank you for your contribution @nyurik 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not sure what each hook does, so proposing this PR to avoid ambiguity
P.S. Note that it is currently a bit unclear if these hooks apply to all the text files, or all files including binaries, etc. Please clarify