Problem
The client-side generation timeout is derived independently in two places in lib/features/chat/presentation/chat_notifier.dart (around line 592), with different non-vision fallback values — 60s in send() vs. 120s in _runAgentTurn — and no shared constant.
Why this matters
A future timeout-tuning change applied to one code path (plain chat) is easily forgotten in the other (agent/tool-call loop), leaving the two flows silently inconsistent for the same kind of request. The vision-specific 300s bump (#57) is duplicated the same way.
Found during v1.2.0 release-readiness code review of the main...develop diff.
Fix direction
Factor the timeout derivation (vision vs. non-vision, and whichever fallback values are actually intended for each flow) into one shared helper/constant used by both send() and _runAgentTurn.
Problem
The client-side generation timeout is derived independently in two places in
lib/features/chat/presentation/chat_notifier.dart(around line 592), with different non-vision fallback values — 60s insend()vs. 120s in_runAgentTurn— and no shared constant.Why this matters
A future timeout-tuning change applied to one code path (plain chat) is easily forgotten in the other (agent/tool-call loop), leaving the two flows silently inconsistent for the same kind of request. The vision-specific 300s bump (#57) is duplicated the same way.
Found during v1.2.0 release-readiness code review of the
main...developdiff.Fix direction
Factor the timeout derivation (vision vs. non-vision, and whichever fallback values are actually intended for each flow) into one shared helper/constant used by both
send()and_runAgentTurn.