fix: add noopener to window.open call in AnnouncementToastProvider#971
Open
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Open
fix: add noopener to window.open call in AnnouncementToastProvider#971LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Conversation
|
@LikiosSedo is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a474c46..227fb01
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/announcements/AnnouncementToastProvider.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noopener,noreferrertowindow.open()call inAnnouncementToastProviderto prevent the opened page from accessingwindow.openerTest plan
window.openerisnullin the opened pageHigh-level PR Summary
This PR adds security parameters
noopenerandnoreferrerto thewindow.open()call in the AnnouncementToastProvider component. This prevents newly opened pages from accessing thewindow.openerproperty, which protects against potential tabnabbing attacks where malicious sites could manipulate the opener page.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/announcements/AnnouncementToastProvider.tsx