fix: remove unnecessary useEffect + useState for AUTH_TYPE constant#974
Open
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Open
fix: remove unnecessary useEffect + useState for AUTH_TYPE constant#974LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Conversation
AUTH_TYPE is a static module-level import that never changes. No need for useState + useEffect; use the constant directly. Closes MODSetter#941
|
@LikiosSedo is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a474c46..97e7e73
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/(home)/login/LocalLoginForm.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useState+useEffectpattern with a direct constant forAUTH_TYPEinLocalLoginForm, since it's a build-time constant that never changesuseEffectimportTest plan
High-level PR Summary
This PR simplifies the
LocalLoginFormcomponent by removing an unnecessaryuseStateanduseEffectpattern used to manage theAUTH_TYPEconstant. SinceAUTH_TYPEis a build-time constant that never changes at runtime, it can be used directly without state management. The unuseduseEffectimport is also removed as a result of this cleanup.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/app/(home)/login/LocalLoginForm.tsx