fix(ui): show skeleton instead of fake star count while loading#977
Open
tysoncung wants to merge 1 commit intoMODSetter:mainfrom
Open
fix(ui): show skeleton instead of fake star count while loading#977tysoncung wants to merge 1 commit intoMODSetter:mainfrom
tysoncung wants to merge 1 commit intoMODSetter:mainfrom
Conversation
…etter#918) Replace the misleading 10000 placeholder with a Skeleton component during the loading state of the GitHub stars badge. This prevents users from thinking 10000 is the actual star count before real data loads. Closes MODSetter#918
|
Someone is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a474c46..b17ce0e
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/homepage/github-stars-badge.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub stars badge displays
10000as a placeholder with a rolling animation while loading. This misleads users into thinking that's the actual star count.Solution
Replace the fake number with a
Skeletonplaceholder component during loading. Once the real star count loads, theAnimatedStarCountdisplays withisRolling={false}.Changes
surfsense_web/components/homepage/github-stars-badge.tsx:Skeletonfrom UI components<Skeleton className="h-4 w-10" />during loadingCloses #918
High-level PR Summary
This PR improves the GitHub stars badge UX by replacing the misleading placeholder count of
10000with aSkeletoncomponent during the loading state. Once the actual star count is fetched, it displays without the rolling animation to avoid confusion about the real number.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/homepage/github-stars-badge.tsx