fix(ui): add type to useEffect dependency in DocumentTypeChip#979
Closed
tysoncung wants to merge 1 commit intoMODSetter:mainfrom
Closed
fix(ui): add type to useEffect dependency in DocumentTypeChip#979tysoncung wants to merge 1 commit intoMODSetter:mainfrom
tysoncung wants to merge 1 commit intoMODSetter:mainfrom
Conversation
…ter#946) The truncation check useEffect had an empty dependency array, so it only ran on mount. If the type prop changed (changing the label text), the truncation state would not update until a window resize event. Add type to the dependency array so the check re-runs when the label changes. Closes MODSetter#946
|
Someone is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a474c46..e8ac02c
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentTypeIcon.tsx
Owner
|
@tysoncung, please raise this PR on the "dev" branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
DocumentTypeChipcomponent checks if the label text is truncated using auseEffectwith an empty dependency array[]. If thetypeprop changes (which changes the label text), the truncation state won't update until a window resize event fires.Solution
Add the
typeprop to theuseEffectdependency array so the truncation check re-runs whenever the document type (and thus the label) changes.Changes
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentTypeIcon.tsx:useEffect(..., [])touseEffect(..., [type])Closes #946
High-level PR Summary
This PR fixes a bug in the
DocumentTypeChipcomponent where the text truncation state wouldn't update when thetypeprop changes. The fix addstypeto theuseEffectdependency array so the truncation check re-runs whenever the document type (and thus the label text) changes, ensuring the truncation detection stays accurate.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentTypeIcon.tsx