fix: replace router.push with Link for static navigation in UserDropdown#983
Merged
MODSetter merged 1 commit intoMODSetter:devfrom Mar 26, 2026
Merged
Conversation
Enables route prefetching and follows Next.js best practices. Removes unused useRouter import.
|
@LikiosSedo is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 0583ad5..f764067
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/UserDropdown.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onClick={() => router.push(...)}with<Link>+asChildfor the API Key menu itemuseRouterimportTest plan
Closes #937
High-level PR Summary
This PR refactors the UserDropdown component to use Next.js
Linkcomponent withasChildinstead ofrouter.push()for navigating to the API Key page. This change enables route prefetching, follows Next.js best practices for static navigation, and removes the now-unuseduseRouterimport.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/UserDropdown.tsx