fix: remove unnecessary "use client" from pure presentational components#984
Merged
MODSetter merged 1 commit intoMODSetter:devfrom Mar 26, 2026
Merged
Conversation
These components only render JSX with props and don't use hooks, event handlers, or browser APIs.
|
@LikiosSedo is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 0583ad5..3d762cc
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (4)
• surfsense_web/app/docs/sidebar-separator.tsx
• surfsense_web/components/Logo.tsx
• surfsense_web/components/announcements/AnnouncementsEmptyState.tsx
• surfsense_web/components/public-chat-snapshots/public-chat-snapshots-empty-state.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"use client"directive from 4 components that are purely presentational:AnnouncementsEmptyState.tsxsidebar-separator.tsxpublic-chat-snapshots-empty-state.tsxLogo.tsxTest plan
Closes #935
High-level PR Summary
This PR optimizes the Next.js application by removing unnecessary
"use client"directives from four purely presentational components (Logo.tsx,sidebar-separator.tsx,AnnouncementsEmptyState.tsx, andpublic-chat-snapshots-empty-state.tsx) that don't require client-side interactivity. This allows these components to be rendered on the server, improving performance and reducing the client-side JavaScript bundle size.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/Logo.tsxsurfsense_web/app/docs/sidebar-separator.tsxsurfsense_web/components/announcements/AnnouncementsEmptyState.tsxsurfsense_web/components/public-chat-snapshots/public-chat-snapshots-empty-state.tsx