Optimize tray icon name handling with OsString and Cow#537
Merged
MalpenZibo merged 1 commit intoMalpenZibo:mainfrom Mar 23, 2026
Merged
Optimize tray icon name handling with OsString and Cow#537MalpenZibo merged 1 commit intoMalpenZibo:mainfrom
MalpenZibo merged 1 commit intoMalpenZibo:mainfrom
Conversation
MalpenZibo
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #529
I fixed the tray icon memory consumption because it was making way too many small allocations and slowing everything down. Now the code uses OsString for the paths and I added Cow for the strings so we don't copy data unless we really have to.
The normalization part is also much faster now because if the string is already good it just leaves it alone, plus I added a LazyLock cache so we don't calculate the same icon names over and over. I also fixed the prefix matching to stop making temporary Vec lists while it looks at characters and it just stops early if it finds an exact match.
All the Vec allocations use
with_capacitynow because we already know the size, so the computer doesn't have to keep moving memory around while the code is running in the hot path.It is already late, maybe I overlooked a few things but this makes things better than before