Add Rollkit crate to Reth#1
Closed
Manav-Aggarwal wants to merge 14 commits into
Closed
Conversation
tac0turtle
reviewed
Jun 17, 2025
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
from a high level the changes make sense based on what we discussed.
| impl Default for RollkitPayloadBuilderConfig { | ||
| fn default() -> Self { | ||
| Self { | ||
| max_transactions: 1000, |
Owner
Author
There was a problem hiding this comment.
it's just a default, can be overrridden
github-merge-queue Bot
pushed a commit
to evstack/ev-node
that referenced
this pull request
Jun 25, 2025
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview - Adds an EVM Full Node setup - Uses a new docker image I pushed to ghcr: ghcr.io/rollkit/rollkit-reth - Tests in execution_test.go work now with a custom transaction payload and an EVM full node syncs transactions properly too - Made a custom reth node for rollkit here: Manav-Aggarwal/reth#1, need to extract it to the Rollkit org <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added documentation and Docker Compose support for running a Rollkit EVM full node, including JWT secret management and persistent log storage. - **Bug Fixes** - Improved transaction ordering and deterministic processing in transaction execution and retrieval. - **Documentation** - Updated instructions for running sequencer and full nodes, clarified service naming, and improved setup guidance in the README. - **Chores** - Updated Docker images, service names, and dependencies in Docker Compose files. - Removed unused dependencies from module configuration. - **Tests** - Enhanced test determinism and verification for transaction execution and state root consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Owner
Author
|
Closing in favor of evstack/ev-reth#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollkit Reth Node