Resolve matrix commute error in model using random effect and GRM at the same time.#372
Merged
MikeDMorgan merged 1 commit intomasterfrom Aug 28, 2025
Merged
Resolve matrix commute error in model using random effect and GRM at the same time.#372MikeDMorgan merged 1 commit intomasterfrom
MikeDMorgan merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a random effect in the formula and a GRM resulted in a matrix multiplication error. The fix was to transpose the sub-matrix of Z subset by the columns of the relevant random effect level. This also revealed an error in the how the results were being collated with multiple random variables if one of them was the GRM/kinship matrix.