Conversation
findNextStep
force-pushed
the
github_build_ci
branch
from
b4b02a0 to
2ce512d
Compare
|
for issue #534 |
|
Would be nice to run the tests too. |
test-index in ccls seem to need clang-6 but I can`t work out with mac, can you help with that? |
|
Will check later, yes |
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
b299069 to
de800eb
Compare
MaskRay
force-pushed
the
github_build_ci
branch
from
2ce512d to
ca04320
Compare
xerrni
left a comment
xerrni
left a comment
There was a problem hiding this comment.
Please also correct commit message from "add github ci integrated" to something more verbose like:
Add github CI integration.
CI will be responsible for compiling source code and code formatting.
.github/workflows/build_linux.yaml
Outdated
| - name: clone submodule | ||
| run: git submodule update --init --recursive | ||
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug |
There was a problem hiding this comment.
cmake -H. -Bbuild/Debug -DCMAKE_BUILD_TYPE=Debug
.github/workflows/build_linux.yaml
Outdated
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug | ||
| - name: make | ||
| run: make -C build/Debug -j |
There was a problem hiding this comment.
cmake --build ./build/Debug
.github/workflows/build_linux.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: install depend | ||
| run: sudo apt install clang libclang-9-dev |
There was a problem hiding this comment.
DEBIAN_FRONTEND="noninteractive" sudo apt -y install clang libclang-9-dev
.github/workflows/build_mac.yaml
Outdated
| - name: clone submodule | ||
| run: git submodule update --init --recursive | ||
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm/lib/cmake |
There was a problem hiding this comment.
cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm -DCMAKE_BUILD_TYPE=DebugThere was a problem hiding this comment.
Also you may wrap this line so it wont be exceed 120 characters.
.github/workflows/build_mac.yaml
Outdated
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm/lib/cmake | ||
| - name: make | ||
| run: make -C build/Debug -j |
There was a problem hiding this comment.
cmake --build ./build/Debug
findNextStep
force-pushed
the
github_build_ci
branch
3 times, most recently
from
46eb5a3 to
11c9884
Compare
CI will be responsible for compiling source code and code formatting.
findNextStep
force-pushed
the
github_build_ci
branch
2 times, most recently
from
5d35dbe to
a4e7b93
Compare
all suggest has accepted |
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
7818055 to
99f0b40
Compare
|
Imo you should do Release builds instead to be able to publish them. |
|
@Trass3r @findNextStep |
MaskRay
force-pushed
the
master
branch
4 times, most recently
from
a33231a to
cb08df4
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996 to
feb153a
Compare
MaskRay
force-pushed
the
master
branch
9 times, most recently
from
94ba2b3 to
c018bce
Compare
|
How about adding a basic Github CI at the beginning, and try to add further CI workflows in further PRs? IHMO a working CI could not only run unit tests, but also be an example of how to build and install this project, as a supplement of the docs. I'd like to take over this PR if it has been stalled |
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
db890d4 to
cc13ced
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
e403622 to
cfc7c02
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
49cbf37 to
aca8280
Compare
5 participants
add github ci integrated
include
I format some code for clang-format ci check